Skip to content

Membership module refactoring #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bedeho merged 15 commits into from
Jun 2, 2020
Merged

Membership module refactoring #490

bedeho merged 15 commits into from
Jun 2, 2020

Conversation

@shamil-gadelshin
Copy link
Contributor

@shamil-gadelshin shamil-gadelshin commented May 27, 2020 •
edited
Loading

Changes

  • incapsulate storage fields MemberIdsByRootAccountId and MemberIdsByControllerAccountId. Remove public access to those fields.
  • rename Profile to Membership, and storage field MemberProfile to MembershipById.
  • rename MembersCreated => NextMemberId.
  • rename Handles => MemberIdByHandle.
  • drop UserInfo.
  • CheckedUserInfo was renamed to the ValidatedUserInfo and kept for simplicity as a private internal structure.
  • drop Option wrapper for around value types of maps
  • remove roles from the membership module
  • remove roles from the content working group module
  • move ActorId from membership to the content working group
  • add MemberId to the content working group Lead
  • move Role from membership to roles module

@shamil-gadelshin shamil-gadelshin added refactoring membership-pallet Membership runtime module labels May 27, 2020
This was linked to issues May 27, 2020
Simplify membership module #115
Closed
Cleanup membershp module #93
Closed
@shamil-gadelshin
Rename Memberships to the MembershipById
1331a84
@shamil-gadelshin
Remove Option from MembershipById storage field
cd252e0
@shamil-gadelshin
Remove Option from the PaidMembershipTerms map
ded12c0
@shamil-gadelshin
Remove Option from ScreeningAuthority in the membership module
459a325
@shamil-gadelshin
Fix comments
41b552e
@shamil-gadelshin
Remove roles from the membership module
05de019 
- remove roles from the membership module
- remove roles from the content working group module
- move ActorId from membership to the content working group
- add MemberId to te content working group Lead
- update tests
- delete commented code
@shamil-gadelshin
Move Role from membership to roles module
3de78ff
@shamil-gadelshin shamil-gadelshin requested a review from bedeho May 28, 2020 15:27
@shamil-gadelshin shamil-gadelshin marked this pull request as ready for review May 28, 2020 15:27
bedeho
bedeho requested changes May 30, 2020
View reviewed changes
@shamil-gadelshin
Copy link
Contributor Author

shamil-gadelshin commented Jun 1, 2020

Several issues were created in order to remove is_member():

@shamil-gadelshin
Refactor content working group
5518094 
Change call from ensure_is_controller_account_for_member() to the ensure_member_controller_account_signed().
@bedeho bedeho merged commit 7841847 into Joystream:membership_cleanup Jun 2, 2020
@shamil-gadelshin shamil-gadelshin mentioned this pull request Jul 16, 2020
Merged
@bedeho bedeho mentioned this pull request Jul 20, 2020
Closed
This was referenced May 24, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bedeho bedeho bedeho approved these changes

Assignees

No one assigned

Labels

membership-pallet Membership runtime module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Simplify membership module Cleanup membershp module

2 participants

@shamil-gadelshin @bedeho